Conversation
|
Caution Review failedThe pull request is closed. WalkthroughUpdated congestion retrieval across services to use a new time-bucketed API (getTimeCongestion) returning Float, replacing getRedisCongestion. Call sites now convert to Int when populating DTOs. PlaceRedisUtil implements time-based keys with 3-hour buckets, TTL, and lazy initialization via setIfAbsent; prior method removed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Svc as Service/Converter/Search
participant Util as PlaceRedisUtil
participant R as Redis
Svc->>Util: getTimeCongestion(placeId[, dateTime])
Util->>Util: Compute 3-hour bucketed key<br/>place:congestion:<id>-YYYY-M-D-HHbucket
Util->>R: GET key
alt Cache hit
R-->>Util: value (Float as String)
Util-->>Svc: Float
else Cache miss
Util->>Util: Generate congestion value
Util->>R: SETNX key value EX 86400
R-->>Util: OK/Already exists
Util->>R: GET key
R-->>Util: value
Util-->>Svc: Float
end
note over Svc: Call sites convert to Int via toInt() when needed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
혼잡도 일관성 보장
Summary by CodeRabbit